Make container_push_official accept optional registry and repository#318
Closed
isakstenstrom wants to merge 1 commit intobuildbarn:mainfrom
Closed
Make container_push_official accept optional registry and repository#318isakstenstrom wants to merge 1 commit intobuildbarn:mainfrom
container_push_official accept optional registry and repository#318isakstenstrom wants to merge 1 commit intobuildbarn:mainfrom
Conversation
This makes it possible to push images to alternative registries without having to reimplement the `container_push_official` rule.
|
Member
|
Hmm... I don't know. What's wrong with just calling |
Contributor
Author
|
I had a problem a while back where our internal builds stopped working for bb-portal, and it turned out to be because we used our own push rule and didn't get a necessary change from bb-storage. That's the motivation behind this, but yes it is a very small problem. |
Member
|
That was likely because of the rules_oci to rules_img migration. My assumption is that this was just a one-time thing. |
Contributor
Author
|
Alright, then this PR is not that useful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to push images to alternative registries without having to reimplement the
container_push_officialrule. It would be nice but it is not a big deal if you don't like it @EdSchouten.