chore: add upload of release artifacts to GitHub releases#319
chore: add upload of release artifacts to GitHub releases#319EdSchouten merged 1 commit intobuildbarn:mainfrom
Conversation
CaerusKaru
force-pushed
the
adam/release
branch
from
c008906 to
bdf1d5f
Compare
|
@EdSchouten not sure the best way to test this, but happy to revert if it doesn't function as expected in this workflow. |
.github/workflows/main.yaml
Outdated
| { | ||
| "if": "matrix.host.upload", | ||
| "name": "Download release artifacts", | ||
| "uses": "actions/download-artifact@v4", |
There was a problem hiding this comment.
So this is downloading the assets that were uploaded previously. Would it make sense to put this in a separate job? That way we also don't run into disk space issues.
Keep in mind that the source of truth for these files is in tools/github_workflows. Please make changes there and run something like this to copy them back into the source tree:
bazel build //tools/github_workflows && cp bazel-bin/tools/github_workflows/*.yaml .github/workflows
There was a problem hiding this comment.
Thanks for the pointer. Should be updated now 👍
CaerusKaru
force-pushed
the
adam/release
branch
from
bdf1d5f to
cfae07b
Compare
CaerusKaru
force-pushed
the
adam/release
branch
from
cfae07b to
be5c7f9
Compare
EdSchouten
left a comment
EdSchouten
left a comment
There was a problem hiding this comment.
LGTM! One final request: can you run jsonnetfmt against the .libsonnet file for me? Thanks!
CaerusKaru
force-pushed
the
adam/release
branch
from
be5c7f9 to
b54d458
Compare
Done, but it removed the newline. Do you want me to put it back? |
|
That's odd. Yes, please! |
CaerusKaru
force-pushed
the
adam/release
branch
from
b54d458 to
956f588
Compare
|
Done 👍 |
|
Here goes nothing! Thanks, @CaerusKaru ! |
|
It looks like this change doesn't work just yet: https://github.com/buildbarn/bb-storage/actions/runs/21838084540/job/63019130341 @CaerusKaru Would you be interested in taking a look? Thanks! |
2 participants
This provides a stable unauthed path for folks to gain access to the compiled release artifacts.