Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test vectors for FastCDC with normalization level 2 (REv2) to support the reference implementation in bazelbuild/remote-apis#357.
Changes:
- Added
TestChunker_SekienNormalization2function with test vectors for normalization level 2 with seeds 0 and 666 - Test validates chunk offsets, lengths, SHA256 hashes, and fingerprints for more comprehensive validation than existing tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tyler-french
force-pushed
the
tfrench/test-vector
branch
from
0d57540 to
a62aafc
Compare
sluongng
approved these changes
Feb 13, 2026
tylerwilliams
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in bazelbuild/remote-apis#357
This test verifies we're aligned with the RemoteAPIs spec bazelbuild/remote-apis@de5501d