added compile step and node module resolution to translucent-blueprint#39
Open
Piefayth wants to merge 3 commits intobutaneprotocol:mainfrom
Open
added compile step and node module resolution to translucent-blueprint#39Piefayth wants to merge 3 commits intobutaneprotocol:mainfrom
Piefayth wants to merge 3 commits intobutaneprotocol:mainfrom
Conversation
4191b4f to
0fd8c5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
bun run buildfrom thetranslucent-blueprintfolder should produce a valid artifact for any platform that supports the node apis now.I found one limitation WRT imports described here. Essentially, typescript won't transpile
import foo from './footoimport foo from './foo.jsno matter what you do. Likewise, the node team specifically refuses to allow./foostyle ESM imports. Luckily, Bun can interpretxxx.jsasxxx.tswhen handling imports, so the simplest solution here is just to usefrom xxx.jsstyle imports intranslucent-blueprint. It sure looks silly, though.Also fixed up the test I added to be a lil more Bun-idiomatic, since I had to touch it anyway.