Skip to content

Work around incompatibility with System.ValueTuple 4.6.1 and add .NET 10 to test matrix #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buvinghausen merged 3 commits into from
Jan 6, 2026
Merged

Work around incompatibility with System.ValueTuple 4.6.1 and add .NET 10 to test matrix #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96a0c7f
Resolve compiler errors when used in a net471+ app along with System.…
jnm2 Nov 12, 2025
df616e0
Remove additional package targets that provide no value
jnm2 Nov 12, 2025
a012e2a
Add .NET 10 to test matrix
jnm2 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
dotnet-version: |
8.0.*
9.0.*
10.0.*
env:
DOTNET_NOLOGO: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 9.0.*
dotnet-version: 10.0.*
env:
DOTNET_NOLOGO: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
<Authors>Joseph Musser,Brian Buvinghausen</Authors>
<Company>Buvinghausen Solutions</Company>
<Copyright>Copyright © 2025 Brian Buvinghausen</Copyright>
Expand Down
6 changes: 1 addition & 5 deletions src/TaskTupleAwaiter/TaskTupleAwaiter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Title>TaskTupleAwaiter</Title>
Expand All @@ -14,8 +14,4 @@ Based on the work of Joseph Musser https://github.com/jnm2
<SupportedPlatform Include="browser" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
<PackageReference Include="System.ValueTuple" Version="4.3.1" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion test/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;net462</TargetFrameworks>
<TargetFrameworks>net10.0;net9.0;net8.0;net462</TargetFrameworks>
<IsPackable>false</IsPackable>
<MSBuildTreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</MSBuildTreatWarningsAsErrors>
<ImplicitUsings>true</ImplicitUsings>
Expand Down