Solid Popover Component #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackWReid
reviewed
Jul 13, 2017
JackWReid
left a comment
JackWReid
left a comment
There was a problem hiding this comment.
Can I get some screenshots up in this
| // Popovers | ||
| // -------------------------------------------------- | ||
| $background-caret-size: .625rem; | ||
| $foreground-caret-size: .5625rem; |
|
|
||
| <a name="pagination"></a> | ||
| <h2 class="bold xs-mb2">Popovers</h2> | ||
| <p class="xs-mb2">Popovers are useful for uncovering helpful information or hints when using a product. Use the <span class="nowrap">.<code class="js-highlight">.popover .popover--right</code></span> classes to incorporate a popover into your project.</p> |
There was a problem hiding this comment.
Is it worth mentioning the grey variant here?
|
I'm not sure this could be made much more readable by a mixin to handle the caret styling. I think this is probably easier to debug that if we put it all in too-clever if statements that might reduce the line count. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.