feat: Download WASI-SDK during build #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteAbeLincoln
force-pushed
the
download-wasi-sdk
branch
from
814b71d to
cd9da5c
Compare
dicej
reviewed
Dec 18, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Thanks for doing this, @WhiteAbeLincoln! LGTM; just one suggestion inline below.
| // how it's given in the github release build pipeline | ||
| let version = match env::var("WASI_SDK_VERSION").ok() { | ||
| Some(v) => v, | ||
| None => bail!("wasi-sdk not found and WASI_SDK_VERSION not set, cannot download"), |
Collaborator
There was a problem hiding this comment.
Currently, WASI-SDK 27 is the only version known to work with componentize-py, so we should probably default to that if WASI_SDK_VERSION is not set. I'm hoping we can support newer versions in the future, but even then we'll be able to pick a reasonable default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
build_zlibstep, it downloads the wasi-sdk to the out directory. This download is performed if the path given by $WASI_SDK_PATH or/opt/wasi-sdkdoes not exist.If $NO_DOWNLOAD_WASI_SDK is set, then we skip the automatic download even if the above path didn't exist when checked.
The download can be controlled using $WASI_SDK_URL to give the full download url, or $WASI_SDK_SOURCE (the github organization) and $WASI_SDK_VERSION (the major version number). $WASI_SDK_VERSION must be provided.
fixes #180