fix: resolve undefined behavior (use-after-free) in Stack::Reserve #121
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactored
Stack::Reserveto calculate the current stack size before callingstd::realloc.Why are the changes needed?
This is a fix for Undefined Behavior.
The previous implementation invoked Size() (which reads buf_) after
std::realloc(buf_, ...)had already executed. According to the C++ standard, the lifetime of the pointer passed to realloc ends immediately upon the call. Any subsequent access to buf_ (even just for pointer arithmetic in Size()) is invalid.Although this issue was recently highlighted by GCC 12's stricter analysis (-Wuse-after-free), it represents a logical flaw that exists in all build environments.
Error context (exposed by GCC 12):