Fix collapse_annotation.py KeyError on UCSC GTFs missing transcript_type#71
Open
Fix collapse_annotation.py KeyError on UCSC GTFs missing transcript_type#71
Conversation
UCSC GTFs (e.g., mm10) lack gene_type/transcript_type attributes that the GTEx pipeline collapse_annotation.py expects, causing a KeyError in the rnaseqc2 step. Added a local patched copy that defaults missing types gracefully and warns about UCSC annotation limitations. Updated the bfx wrapper to use the local script instead of the module-provided one.
Collaborator
|
Thanks for doing this, Senthil. We might want to think about adding the script to c3g_tools instead of having it in the genpipes tools directory. The genpipes tools directory is more for tools that are genpipes specific, whereas script like collapse_annotation.py are usually housed under c3g_tools. What do you think, Paul? |
Collaborator
|
I agree with Mareike. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gene_type/transcript_typeattributes that the GTEx pipeline'scollapse_annotation.pyexpects, causing aKeyErrorin thernaseqc2stepgenpipes/tools/collapse_annotation.py) that defaults missing types gracefully and warns about UCSC annotation limitationsgenpipes/bfx/gtex_pipeline.pyto use the local script instead of the module-provided oneTest plan
collapse_gtfstep completes withoutKeyErrorgene_type/transcript_type