Skip to content

Comments

added the option for the plugin to render hypothesis elements as links#23

Open
anotherdish wants to merge 1 commit intoc6p:mainfrom
anotherdish:main
Open

added the option for the plugin to render hypothesis elements as links#23
anotherdish wants to merge 1 commit intoc6p:mainfrom
anotherdish:main

Conversation

@anotherdish
Copy link

basically this code just implements an option that allows the hypothesis items that get rendered to be clickable links that take you directly to the source item

this allows us to do things like what is possible with the logseq pdf annotations, where the highlights are clickable and take you directly to the line in the PDF

…s a link that will open up the element in the browser
@anotherdish
Copy link
Author

also, im assuming that the reason for putting the hid annotation in each of the items is because we want to be able to revisit the highlight/annotation later, but if we have links that will take users directly back to the annotation then you can probably just get rid of putting the annotation in right? I'm separately having an issue with multi-line highlights, where the annotation gets rendered at the end of the first newline... i might look into it sometime later this week

image

@c6p
Copy link
Owner

c6p commented Feb 10, 2025

Sorry for being this late, I missed the PRs. I like the idea. But, it has to wait a little bit more.

I'm planning to make some changes to how annotations are rendered. It will be similar to how logseq renders PDF annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants