Skip to content

Conversation

@austin362667
Copy link
Collaborator

v2

c9s and others added 30 commits June 29, 2023 17:18
…r-mm

FEATURE: add risk controls for strategies
FIX: [grid2] use tryLock during the openGrid process
REFACTOR: [bollmaker] upgrade to indicator v2
bailantaotao and others added 22 commits July 26, 2023 14:18
…ders

pkg/exchange: add QueryOpenOrders API for bybit
…-query-closed-order

FIX: [max] return err on max queryClosedOrdersByLastOrderID
FEATURE: [max] add fee_discounted to Trade struct for RESTful api
…-end-time

FIX: fix batch query trade missing time range
merge back v1.50 into main
@bbgokarma-bot
Copy link

Welcome back! @austin362667, This pull request may get 257 BBG.

@austin362667 austin362667 requested a review from c9s July 31, 2023 13:32
@c9s c9s changed the title Indicator: Add VWAP FEATURE: [indicator] Add VWAP indicator Jul 31, 2023
return s
}

func (s *VWAPStream) calculate() float64 {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check both the rawCloseValues, rawVolumeValues length, because it could trigger twice since you have 2 update callbacks, or you can subscribe the KLine stream

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants