Fix/filter username input #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssefontainecagip
force-pushed
the
fix/filter_username_input
branch
from
d1f19b0 to
c8e3f85
Compare
evrardjp
approved these changes
Apr 13, 2023
Contributor
evrardjp
left a comment
evrardjp
left a comment
There was a problem hiding this comment.
I didn't test this myself, but the tests do make sense.
evrardjp
requested changes
Apr 13, 2023
ulyssefontainecagip
force-pushed
the
fix/filter_username_input
branch
from
c8e3f85 to
867c9dc
Compare
Author
|
CI changes was moved to PR #25 👍 |
Contributor
|
@zkonak can you check why this is pending? |
Without this, it is possible to do an ldap query injection. This is a problem as it is a possible vulnerability issue. However, it is very unlikely to arrive to real case exploitation, as the input is admin given. This fixes it by ensuring filtering with a regexp and adding the appropriate tests (here done with fuzzing). Co-Authored-By: Jean-Philippe Evrard <jean-philippe.evrard-prestataire@ca-gip.fr>
evrardjp-cagip
force-pushed
the
fix/filter_username_input
branch
from
867c9dc to
71826e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.