Fix ldap search with pagination bug #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfhcagip
force-pushed
the
fixLdapSearchPagination
branch
from
e63e1e4 to
71f0463
Compare
When making a ldap search, the pagination was managed both by the ldap search library and the calling code. This lead to a fatal error when the number of results exceeded the page size. This issue has been fixed by removing the pagination management in the calling code. The pagination is thus managed only by the ldap library
jfhcagip
force-pushed
the
fixLdapSearchPagination
branch
from
71f0463 to
84d5b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a ldap search, the pagination was managed both by the ldap search library and the calling code. This lead to a fatal error when the number of results exceeded the page size. This issue has been fixed by removing the pagination management in the calling code. The pagination is thus managed only by the ldap library