This repository was archived by the owner on Apr 9, 2020. It is now read-only.
Merged
Conversation
Owner
|
Not sure the test.c is particularly portable, as evidenced by (and the lack of a return...), but this should be an innocuous change. |
Contributor
Author
Section
So you probably don't need a return statement in that function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading cabos comment in #44 I wondered if cn-cbor actually compiles with C compilers other than gcc and clang and tested this by compiling it with pcc using the
Simple-Makefile.pcc complained that the function declaration for
mainintest.cis incorrect and according to section5.1.2.2.1of the C99 standard pcc is actually right about this.