This repository was archived by the owner on Apr 9, 2020. It is now read-only.
cn-encoder: Fix -Wdouble-promotion by explicit cast#56
Open
jnohlgard wants to merge 1 commit intocabo:masterfrom
Open
cn-encoder: Fix -Wdouble-promotion by explicit cast#56jnohlgard wants to merge 1 commit intocabo:masterfrom
jnohlgard wants to merge 1 commit intocabo:masterfrom
Conversation
The intention of this line of code is to check whether the conversion to float reduced the precision of the value, hence the conversion to double is correct here, but when compiled with GCC's -Wdouble-promotion, this implicit cast to double will trigger a warning. The fix for the warning is to make the cast explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of this line of code is to check whether the conversion to float
reduced the precision of the value, hence the conversion to double is correct
here, but when compiled with GCC's -Wdouble-promotion, this implicit cast to
double will trigger a warning. The fix for the warning is to make the cast
explicit.