Skip to content

chore: Remove linux-tools-generic from profiling Dockerfile #1863

Merged
rtb-12 merged 1 commit intomasterfrom
fix-ci-profiling-dockerfile-linux-tools
Feb 5, 2026
Merged

chore: Remove linux-tools-generic from profiling Dockerfile #1863
rtb-12 merged 1 commit intomasterfrom
fix-ci-profiling-dockerfile-linux-tools

Conversation

@rtb-12
Copy link
Contributor

@rtb-12 rtb-12 commented Feb 5, 2026

[release] Fix profiling Docker image apt install flake

Description

Remove linux-tools-generic from the profiling Dockerfile to stop random CI failures in the container-release-profiling job. The meta-package depends on a kernel-version-specific package (e.g. linux-tools-6.8.0-100-generic) that is sometimes not yet available in Ubuntu mirrors, causing "Unable to correct problems, you have held broken packages" and exit code 100.

Perf in the container must match the host kernel anyway, so installing linux-tools-generic at build time is unnecessary. The entrypoint already installs the correct linux-tools-${kernel_version} at runtime via install_kernel_tools(). Only linux-tools-common is kept for the base tooling.

No other code or workflow changes; only the Dockerfile and an explanatory comment were updated.

Test plan

  • Re-run the release workflow and confirm the Docker build completes. Optionally run the profiling image locally and confirm perf is still available when the host provides matching kernel tools (or that the entrypoint reports the expected warning when perf is not installable).

Documentation update

None. The Dockerfile comment documents why linux-tools-generic is omitted and how to mount the host’s perf if needed.


Note

Low Risk
Single-package removal in a Docker build step; main risk is perf availability in the resulting image if runtime tooling isn’t provided elsewhere.

Overview
Removes linux-tools-generic from the profiling prebuilt Dockerfile’s apt install list, leaving linux-tools-common as the base dependency.

This reduces CI flakiness caused by kernel-version-specific linux-tools-* dependencies being unavailable in Ubuntu mirrors during image builds.

Written by Cursor Bugbot for commit 6446fe3. This will update automatically on new commits. Configure here.

Copy link

@meroreviewer meroreviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Code Reviewer

Reviewed by 1 agents | Quality score: 85% | Review time: 72.5s


💡 Suggestion (1)

1. Missing explanatory comment mentioned in PR description

File: .github/workflows/deps/prebuilt.profiling.Dockerfile (line 17-18) | Consensus: 1/1 agents ✓

The PR description states 'The Dockerfile comment documents why linux-tools-generic is omitted and how to mount the host's perf if needed', but the diff only shows removal of lines without adding any explanatory comment. This documentation would be valuable for future maintainers to understand why linux-tools-generic was intentionally excluded and prevent someone from re-adding it.

Suggested fix:

Add a comment above linux-tools-common explaining: '# Note: linux-tools-generic is intentionally omitted - it depends on kernel-version-specific packages that may not be available in mirrors. The entrypoint script installs the correct linux-tools-${kernel_version} at runtime to match the host kernel.'

Found by: cursor-agent

📝 Nitpick (1)

1. Removed section comment leaves package without context

File: .github/workflows/deps/prebuilt.profiling.Dockerfile (line 17-17) | Consensus: 1/1 agents ✓

The '# Profiling tools' comment was removed along with linux-tools-generic, leaving linux-tools-common without a descriptive comment explaining its purpose. While not critical, section comments help organize the package list and clarify intent.

Suggested fix:

Consider adding a brief comment like '# Perf base tooling (kernel-specific tools installed at runtime)' above linux-tools-common

Found by: cursor-agent


🤖 Generated by AI Code Reviewer | Review ID: review-6f535162

@rtb-12 rtb-12 merged commit 3a66350 into master Feb 5, 2026
20 checks passed
@rtb-12 rtb-12 deleted the fix-ci-profiling-dockerfile-linux-tools branch February 5, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants