-
Notifications
You must be signed in to change notification settings - Fork 6
Some minor fixes in api annotations #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update API documentation annotations in multiple route files by replacing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/routes/projects.ts (2)
91-96: Parameter casing inconsistency (AdminIdvsadminId)
Create-endpoint usesAdminId(capital A) while the update endpoint (below) usesadminId. Pick one spelling to avoid consumer confusion and validation bugs.- * @apiBody (FormData) {UUID} AdminId ID of the admin creating the project + * @apiBody (FormData) {UUID} adminId ID of the admin creating the project
112-116: Mixed annotation scopes – “Body”, “Request Body”, “FormData”
In this block you introduced(Body)and(Form Data)whereas the create endpoint uses(FormData)and the members endpoint uses(Request Body). Pick one of the three so ApiDoc groups them together.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitignore(1 hunks)src/routes/achievements.ts(2 hunks)src/routes/interviews.ts(2 hunks)src/routes/projects.ts(3 hunks)
🔇 Additional comments (4)
.gitignore (1)
142-143: Double-check whether/docshould be ignored in all environments
Ignoring generated docs keeps the repo clean, but make sure the CI/CD (or whatever publishes the API docs) does not rely on committing that folder. If a later step expects/docto exist in the repo, this rule will break the pipeline.src/routes/achievements.ts (1)
56-58: API-Doc tag switch is correct – no issues spotted
@apiParam➔@apiBodyis the right choice for body/form-data params. No functional impact.Also applies to: 77-79
src/routes/interviews.ts (1)
65-70: Documentation tags updated consistently – looks good
The change aligns with the new convention and will generate cleaner docs.Also applies to: 84-89
src/routes/projects.ts (1)
167-168: Good switch to@apiBody
The members endpoint now documents its request body correctly.
Summary by CodeRabbit
@apiBodyinstead of@apiParamfor request body and form data parameters across achievements, interviews, and projects endpoints..gitignoreto exclude the/docdirectory from version control.