make passout year optional

[Harish-Naruto]

Summary by CodeRabbit

• New Features
  • The "Passout Year" field for members is now optional, allowing you to leave it blank when adding or editing member information.

[coderabbitai]

Walkthrough

The changes make the passoutYear field in the Member model optional by updating the Prisma schema and generating a corresponding migration. The database now allows passoutYear to be null, and the schema reflects this by changing its type to DateTime?.

Changes

File(s)	Change Summary
prisma/schema.prisma	Changed passoutYear in Member model from required to optional.
prisma/migrations/20250727111821_passoutyear_optional/...	Migration script drops NOT NULL constraint on passoutYear column.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A bunny hopped through fields of code,
Where passout years could now erode—
No longer bound by strict constraint,
Optional dates, no need to faint!
The schema smiles, the database cheers,
For nullable fields bring fewer tears.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch migration-update

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

prisma/schema.prisma (1)

29-29: Consider storing year as a numeric type instead of DateTime

passoutYear now becomes optional, which solves the immediate requirement.
However, using DateTime to capture a year introduces unnecessary precision (day, time-of-day, timezone) and can complicate comparisons / aggregations (e.g., EXTRACT(YEAR FROM …) everywhere).

A leaner, semantically clearer mapping would be a plain integer (or SmallInt) column that stores the 4-digit year:

-  passoutYear   DateTime?
+  // Stores 4-digit graduation year, e.g., 2024
+  passoutYear   Int? @db.SmallInt

Benefits:
• Removes superfluous date parts.
• Simplifies client validation (year >= 1900 && year <= currentYear).
• Index footprint is smaller.

If you adopt this refactor, remember to adjust the migration (ALTER COLUMN TYPE smallint USING EXTRACT(YEAR FROM passoutYear) or create a fresh one) and update any Prisma query filters that relied on DateTime.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f50c0b and d6e2195.

📒 Files selected for processing (2)

• prisma/migrations/20250727111821_passoutyear_optional/migration.sql (1 hunks)
• prisma/schema.prisma (1 hunks)

🔇 Additional comments (1)

prisma/migrations/20250727111821_passoutyear_optional/migration.sql (1)

1-2: Double-check downstream handling of passoutYear after dropping NOT NULL

The migration cleanly makes passoutYear nullable, but we still have code assuming a defined value. In src/services/member.service.ts:

• Line 45: passoutYear?: number,
• Line 53: passoutYear: passoutYear === undefined ? "" : new Date(passoutYear),

Please review these spots (and any other read/write paths) to ensure that null or undefined now coming from the database is handled safely (e.g., adjust the mapping, update type definitions, or normalize null → undefined).