Merged
Conversation
- Add support for `jwilsson/spotify-web-api-php` v6 and v7 - Migrate service configuration from XML to PHP format (fixes Symfony 7.4+ deprecation) - Align CI workflow with comprehensive PHP 8.2-8.5 and Symfony 6.4-8.0 test matrix
Remove ull argument placeholders from services.php to avoid PHPStan errors in consuming projects. Use setArguments() instead of eplaceArgument() in the extension since arguments are no longer predefined.
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the Symfony bundle by migrating service configuration from XML to PHP, expanding support for newer dependencies, and updating the CI test matrix. Key improvements include simplified dependency injection configuration and broader compatibility testing.
Key Changes:
- Migrated service definitions from XML to PHP-based configuration for modern Symfony practices
- Added support for jwilsson/spotify-web-api-php v7 alongside v6
- Expanded CI testing to cover more Symfony versions and PHP combinations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Resources/config/services.xml | Removed legacy XML service configuration file |
| src/Resources/config/services.php | Added modern PHP-based service configuration with improved readability |
| src/DependencyInjection/CalliostroSpotifyWebApiExtension.php | Updated to use PhpFileLoader and changed from replaceArgument to setArguments for cleaner service configuration |
| composer.json | Expanded spotify-web-api-php dependency to support both v6 and v7 |
| README.md | Added documentation for v6/v7 support and improved formatting |
| .github/workflows/ci.yml | Broadened CI coverage with additional branch triggers and expanded Symfony/PHP test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the Symfony bundle's service configuration, updates compatibility for newer versions of dependencies, and improves CI coverage. The most important changes are grouped below:
Service Configuration Modernization:
services.xml) to PHP-based configuration (services.php), simplifying and modernizing the dependency injection setup. The extension now usesPhpFileLoaderand sets service arguments explicitly. (src/DependencyInjection/CalliostroSpotifyWebApiExtension.php,src/Resources/config/services.php,src/Resources/config/services.xml) [1] [2] [3]Dependency and Compatibility Updates:
jwilsson/spotify-web-api-phpto include both v6 and v7 incomposer.jsonand documented this in theREADME.md. (composer.json,README.md) [1] [2].github/workflows/ci.yml)Continuous Integration Improvements:
legacy/*,feature/*,hotfix/*, andrelease/*branches, not justmain. (.github/workflows/ci.yml).github/workflows/ci.yml) [1] [2]Documentation Enhancements:
README.md. [1] [2]