Skip to content

feat: Disable task overlay when wikilink has an alias (display text) #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jldiaz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Disable task overlay when wikilink has an alias (display text) #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/editor/ReadingModeTaskLinkProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ export class ReadingModeTaskLinkProcessor {
displayText = linkContent;
}

if (displayText) {
// If there's a display text (alias), do not replace the link
return;
}

// Create a task widget instance
const widget = new TaskLinkWidget(taskInfo, this.plugin, originalText, displayText);

Expand Down
8 changes: 6 additions & 2 deletions src/editor/TaskLinkOverlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,13 +280,17 @@ export function buildTaskLinkDecorations(
: parseMarkdownLinkSync(link.match);
if (!parsed) continue;

const { linkPath } = parsed;

const { linkPath, displayText } = parsed;
// Validate link path
if (!linkPath || typeof linkPath !== "string" || linkPath.trim().length === 0) {
continue;
}

// Disable overlay if there's a display text (alias)
if (displayText) {
continue;
}

// Resolve the link path
const resolvedPath = resolveLinkPathSync(linkPath, currentFile, plugin);
if (!resolvedPath) continue;
Expand Down