Skip to content

Conversation

@FabrizioMoggio
Copy link
Collaborator

@FabrizioMoggio FabrizioMoggio commented Aug 20, 2025

What type of PR is this?

  • documentation

What this PR does / why we need it:

This is the M4 PR for the public version of the CFS API, for the Fall25 Meta Release. The PR changes the API version from WIP to 0.4.0 ad provides the updated README.md and CHANGELOG.md files.

Which issue(s) this PR fixes:

#205

@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 1, 2025

@FabrizioMoggio Look good for me. I just wondering if we have a final decision for the attributes order in ErrorMessage. I understood this is still discussed. Let's wait final decision and then happy to approve.

@FabrizioMoggio
Copy link
Collaborator Author

camaraproject/Commonalities#515

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release PR looks good.
there are a few typos, and the optional ErrorInfo order to be corrected if you so decide.

Note: For now, the RM team is holding actual approvals till next tuesday

@FabrizioMoggio FabrizioMoggio marked this pull request as draft September 8, 2025 06:51
@tanjadegroot
Copy link
Contributor

@fabrizio: are you including any linting ?
you may want to apply it on main before republishing the release PR.
I do not know how to do it so you would need to as @hdamker or @rartych I think

@hdamker
Copy link
Contributor

hdamker commented Sep 8, 2025

you may want to apply it on main before republishing the release PR.
I do not know how to do it so you would need to as @hdamker or @rartych I think

@tanjadegroot all good, linting is deployed in the repository like in all Fall25 repositories. It's not very visible as long all is ok (green checkmarks on the commits, "All checks have passed" in the merge area (open the details with the arrow). Or you look on "Checks" tab (between "Commits" and "Files changed".

@tanjadegroot
Copy link
Contributor

you may want to apply it on main before republishing the release PR.
I do not know how to do it so you would need to as @hdamker or @rartych I think

@tanjadegroot all good, linting is deployed in the repository like in all Fall25 repositories. It's not very visible as long all is ok (green checkmarks on the commits, "All checks have passed" in the merge area (open the details with the arrow). Or you look on "Checks" tab (between "Commits" and "Files changed".

Ah, thank you @hdamker - I learned something today. not sure why on some APIs the megalinter report sows up and not on other, but I guess the new central approach may imply that report in on this checks tab - very good !

@FabrizioMoggio FabrizioMoggio marked this pull request as ready for review September 9, 2025 07:37
@tanjadegroot
Copy link
Contributor

Many thanks for the updates ! I did final the review and all is OK for me.
Am awaiting the decision on this afternoon's Release Mgmt call before giving the final approval from Release Management.

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Release Management - all good to go !

@FabrizioMoggio
Copy link
Collaborator Author

@bigludo7, @chinaunicomyangfan can you please approve?

@FabrizioMoggio
Copy link
Collaborator Author

@bigludo7 , @chinaunicomyangfan is there any doubt?

@bigludo7
Copy link
Collaborator

@FabrizioMoggio Oups sorry - Too many Release-related email - I approve now :)

@FabrizioMoggio FabrizioMoggio merged commit e7629fa into camaraproject:main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants