-
Notifications
You must be signed in to change notification settings - Fork 6
M4 - V0.4.0 public #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M4 - V0.4.0 public #204
Conversation
from wip to 0.4.0
|
@FabrizioMoggio Look good for me. I just wondering if we have a final decision for the attributes order in ErrorMessage. I understood this is still discussed. Let's wait final decision and then happy to approve. |
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release PR looks good.
there are a few typos, and the optional ErrorInfo order to be corrected if you so decide.
Note: For now, the RM team is holding actual approvals till next tuesday
documentation/API_documentation/call-forwarding-signal-API-Readiness-Checklist.md
Show resolved
Hide resolved
Alignment with main
@tanjadegroot all good, linting is deployed in the repository like in all Fall25 repositories. It's not very visible as long all is ok (green checkmarks on the commits, "All checks have passed" in the merge area (open the details with the arrow). Or you look on "Checks" tab (between "Commits" and "Files changed". |
Ah, thank you @hdamker - I learned something today. not sure why on some APIs the megalinter report sows up and not on other, but I guess the new central approach may imply that report in on this checks tab - very good ! |
|
Many thanks for the updates ! I did final the review and all is OK for me. |
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Release Management - all good to go !
|
@bigludo7, @chinaunicomyangfan can you please approve? |
|
@bigludo7 , @chinaunicomyangfan is there any doubt? |
|
@FabrizioMoggio Oups sorry - Too many Release-related email - I approve now :) |
What type of PR is this?
What this PR does / why we need it:
This is the M4 PR for the public version of the CFS API, for the Fall25 Meta Release. The PR changes the API version from WIP to 0.4.0 ad provides the updated README.md and CHANGELOG.md files.
Which issue(s) this PR fixes:
#205