Skip to content

Conversation

@eric-murray
Copy link
Contributor

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of:

  • device-reachability-status v1.1.0
  • device-reachability-status-subscriptions v0.8.0

Which issue(s) this PR fixes:

Fixes #38

Special notes for reviewers:

None

Changelog input

 release-note
 - Publication of Fall'25 M4 public release of device-reachability-status v1.1.0 and device-reachability-status-subscriptions v0.8.0

Additional documentation

None

Copy link
Contributor

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric
Same small comment for the readiness checklist than for Roaming.

As for roaming I approve this PR but not hit the approve button to avoid confusion with release management request for review.

sachinvodafone and others added 5 commits September 10, 2025 10:05
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-createDeviceReachabilityStatusSubscription.feature

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-retrieveDeviceReachabilityStatusSubscriptionList.feature

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-deleteDeviceReachabilityStatusSubscription.feature

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@bigludo7 bigludo7 requested a review from Kevsy September 10, 2025 12:49
@bigludo7
Copy link
Contributor

Hi @Kevsy - we did requested change with @sachinvodafone

@Kevsy
Copy link
Contributor

Kevsy commented Sep 10, 2025

Hi @Kevsy - we did requested change with @sachinvodafone

Thanks @bigludo7 - just need the confirmation of the API description, see #47

@bigludo7
Copy link
Contributor

Hi @Kevsy - we did requested change with @sachinvodafone

Thanks @bigludo7 - just need the confirmation of the API description, see #47

Thanks @Kevsy for the heads up - done :)

@Kevsy
Copy link
Contributor

Kevsy commented Sep 10, 2025

Thanks @bigludo7 - one more thing - please can you edit L483 of device-reachability-status-subscriptions.yaml to remove "Up to API project decision to keep it." as per the Discussion 😉

@bigludo7
Copy link
Contributor

@Kevsy Removed ! I found 3 of them and removed all of them.

Kevsy
Kevsy previously approved these changes Sep 10, 2025
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@bigludo7 bigludo7 self-requested a review September 10, 2025 15:25
bigludo7
bigludo7 previously approved these changes Sep 10, 2025
@bigludo7
Copy link
Contributor

@sachinvodafone could you please also approve in order to have formally 2 code owners. I will then finish the process - thanks !

sachinvodafone
sachinvodafone previously approved these changes Sep 11, 2025
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the link to Commonalities r2.3 into the deprecated API Design Guideline Document. See camaraproject/Commonalities#531 for further background and potential short-term solution.

description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification).

@bigludo7 bigludo7 dismissed stale reviews from sachinvodafone, Kevsy, and themself via f72e975 September 15, 2025 15:41
@bigludo7
Copy link
Contributor

Following @hdamker the subscriptionId attribute description has been fixed to remove deprecated link. We will need your review & approval. Thanks

@Kevsy
Copy link
Contributor

Kevsy commented Sep 16, 2025

Following the Commonalities decision to accept the amended event-subscription-template text, I'm happy to re-approve 👍

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@hdamker hdamker dismissed their stale review September 16, 2025 12:06

Requested change is done.

@bigludo7 bigludo7 merged commit d958ab7 into camaraproject:main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the public release r1.2 for Fall25

5 participants