-
Notifications
You must be signed in to change notification settings - Fork 5
Release r1.2 (Fall'25 M4) #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.2 (Fall'25 M4) #45
Conversation
…ityStatusSubscription.feature
…ityStatusSubscription.feature
…ilityStatusSubscription.feature
…ilityStatusSubscriptionList.feature
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric
Same small comment for the readiness checklist than for Roaming.
As for roaming I approve this PR but not hit the approve button to avoid confusion with release management request for review.
.../device-reachability-status-subscriptions-createDeviceReachabilityStatusSubscription.feature
Outdated
Show resolved
Hide resolved
.../device-reachability-status-subscriptions-deleteDeviceReachabilityStatusSubscription.feature
Outdated
Show resolved
Hide resolved
...evice-reachability-status-subscriptions-retrieveDeviceReachabilityStatusSubscription.feature
Outdated
Show resolved
Hide resolved
...e-reachability-status-subscriptions-retrieveDeviceReachabilityStatusSubscriptionList.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-createDeviceReachabilityStatusSubscription.feature Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-retrieveDeviceReachabilityStatusSubscriptionList.feature Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…-deleteDeviceReachabilityStatusSubscription.feature Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
…ilityStatusSubscriptionList.feature
|
Hi @Kevsy - we did requested change with @sachinvodafone |
Thanks @bigludo7 - just need the confirmation of the API description, see #47 |
Thanks @Kevsy for the heads up - done :) |
|
Thanks @bigludo7 - one more thing - please can you edit L483 of device-reachability-status-subscriptions.yaml to remove "Up to API project decision to keep it." as per the Discussion 😉 |
|
@Kevsy Removed ! I found 3 of them and removed all of them. |
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
|
@sachinvodafone could you please also approve in order to have formally 2 code owners. I will then finish the process - thanks ! |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the link to Commonalities r2.3 into the deprecated API Design Guideline Document. See camaraproject/Commonalities#531 for further background and potential short-term solution.
DeviceReachabilityStatus/code/API_definitions/device-reachability-status-subscriptions.yaml
Line 830 in e2eed19
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification). |
f72e975
|
Following @hdamker the subscriptionId attribute description has been fixed to remove deprecated link. We will need your review & approval. Thanks |
|
Following the Commonalities decision to accept the amended event-subscription-template text, I'm happy to re-approve 👍 |
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
What type of PR is this?
What this PR does / why we need it:
Publication of Fall'25 M4 public release of:
Which issue(s) this PR fixes:
Fixes #38
Special notes for reviewers:
None
Changelog input
Additional documentation
None