-
Notifications
You must be signed in to change notification settings - Fork 7
Release r2.1 with NSB v0.2.0-rc.1 and NSA v0.1.0-rc.1 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all,
quite some comments on the new API
I recommend to
- change this to a DRAFT Release PR, do the changes on main in normal PRs.
- wait for the Release PRs of Commonalities and ICM to be available and do the relevant adjustments (if any)
- then re-open and resynch the Release PR only after all required changes are done
documentation/API_documentation/network-slice-assignment-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/network-slice-assignment-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/network-slice-booking-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
|
@tanjadegroot, thanks for your review. We have addressed comments and updated the code accordingly. Please take another look when you have a moment. Most of problems are fixed in [Modify network-slice-assignment API Path and Feature Files #96](#96):
Version problems are modified in this PR:
|
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Release r2.1 with network-slice-booking v0.2.0-rc.1 and network-slice-assignment v0.1.0-rc.1
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input