Skip to content

Conversation

@patrice-conil
Copy link

Some Class Names are in SNAKE_CASE but should be in CamelCase

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

This PR fixes issue #107 by renaming classes and of course increments spec version

Which issue(s) this PR fixes:

Fixes #107

Special notes for reviewers:

Only changes NO_DATA, LOW_DENSITY and DENSITY_ESTIMATION class names

Changelog input

 release-note

NO_DATA => NoData
LOW_DENSITY => LowDensity
DENSITY_ESTIMATION => DensityEstimation



@jgarciahospital
Copy link
Collaborator

pending to review API version (and path) and AP testplan modifications

Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
@patrice-conil
Copy link
Author

pending to review API version (and path) and AP testplan modifications

Hi @jgarciahospital,
I think there is no impact on the test plan as it only refers to the discriminator values ​​which remain unchanged.

@bigludo7
Copy link
Collaborator

bigludo7 commented Nov 3, 2025

Hello @jgarciahospital @sachinvodafone @maheshc01
Kind reminder for this one - Any blocking for merging this one?
Thanks

CampusOxide
CampusOxide previously approved these changes Nov 3, 2025
sachinvodafone
sachinvodafone previously approved these changes Nov 3, 2025
@sachinvodafone
Copy link
Collaborator

Please ignore my another github user (@CampusOxide) approval on this

@patrice-conil
Copy link
Author

Hello, path updated to /vwip as requested by @jgarciahospital

@sachinvodafone sachinvodafone dismissed CampusOxide’s stale review November 10, 2025 10:09

This is another account of Sachin' so please ignore this request.

Copy link
Contributor

@albertoramosmonagas albertoramosmonagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some model names use SNAKE_CASE in place of CamelCase

6 participants