Skip to content

Conversation

@hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 23, 2025

What type of PR is this?

  • Enhancement

What this PR does / why we need it:

Merging this PR and update #229 with main afterwards will eliminate most of the changes from the release PR which are not belonging there, but there will also the need to resolve some conflicts. Happy to help with that.

Which issue(s) this PR fixes:

Fixes # no issue created, but see #229 (comment)

Special notes for reviewers:

I assumed that the content of f3d400a, as already reviewed in #229

Changelog input

 Alignment with latest changes of Commonalities in release r3.3

Additional documentation

This section can be blank.

docs

hdamker and others added 3 commits August 23, 2025 16:20
Intentionally not touched the .feature files
according to discussion in camaraproject/Commonalities#515 and aligned with API Design Guide
@hdamker hdamker added the enhancement New feature or request label Aug 23, 2025
@hdamker hdamker requested a review from maxl2287 as a code owner August 23, 2025 14:46
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ OPENAPI spectral 2 0 3.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.78s
✅ YAML yamllint 2 0 0.55s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit 53cfa38 into main Aug 25, 2025
2 checks passed
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 25, 2025

@bigludo7 don't forget to delete the branches, especially if they are within the upstream repository.

@bigludo7
Copy link
Collaborator

@bigludo7 don't forget to delete the branches, especially if they are within the upstream repository.

Sure ! I deleted them when I'm the author usually :) - I will deleted this one.

@bigludo7 bigludo7 deleted the feature/alignment-with-commonalities branch August 25, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants