Skip to content

Conversation

@Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Aug 26, 2025

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 release r2.2 of SimpleEdgeDiscovery v2.0.0

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for reviewers:

Changelog input

 release-note
 - Publication of Fall'25 M4 public release of simple-edge-discovery v0.2.0

Additional documentation

This section can be blank.

docs


NOTE: SimpleEdgeDiscovery is part of the EdgeCloud API Sub Project, and was previously developed within the [EdgeCloud](https://github.com/camaraproject/EdgeCloud) repository. Two releases were made within EdgeCloud, v0.81 and r0.9.3-rc. These releases also include the other EdgeCloud APIs and materials, so the changelog below highlights only the changes related to SimpleEdgeDiscovery. Further information and links to the releases in EdgeCloud can be found below.

# r2.1 - rc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that r2.1 has been replaced with r2.2.
my understanding is that r2.1 needs to be retained and a new section for r2.2 needs to be added. like how the table of contents has it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mahesh - good catch, I've put it back now.

@maheshc01
Copy link
Contributor

looks good

maheshc01
maheshc01 previously approved these changes Aug 27, 2025
@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 4, 2025

Note to reviewers: I will rebase this M4 PR to account for the fix to #130 (ErrorInfo order reversed) - please wait to review until I have confirmed that has been completed.

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 4, 2025

Note to reviewers: I will rebase this M4 PR to account for the fix to #130 (ErrorInfo order reversed) - please wait to review until I have confirmed that has been completed.

OK that's now fixed, but @rartych is going to update the linting first before further review by release-management-reviewers.

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 4, 2025

OK all good now for the release-management-reviewer to proceed 👍

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some error cases are not covered by any tests, for a v2 API I think these should be added, but up to team to decide if to do now or for the next release.

One small fix needed in the Changelog.
all the rest is ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test scenarios for the errors 400 and 401 in the .feature fil
the last scenario on test for error 500 internal can be removed

Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 15, 2025

Thanks @tanjadegroot - CHANGELOG.MD fix made.

Some error cases are not covered by any tests, for a v2 API I think these should be added, but up to team to decide if to do now or for the next release.

One small fix needed in the Changelog. all the rest is ok

I have created PR #135 to add the 400 and 401 scenarios/remove the #500/tidy up. If a codeowner can approve in time then I can merge into the M4 PR.

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 15, 2025

HI @tanjadegroot , I've updated the errors in a separate PR which has now been merged to wip main and then synched into the M4 PR. So if you expand the .feature file in the M4 PR code you will see new 400 and 401 errors and the 500 removed.

CHANGELOG.md Outdated

## Table of contents

- [r2.2](#r22---(Fall25-public-release))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevsy the link does not work:

option 1) try
line 7: r2.2
or
line 7: r2.2

option 2) if above does not work: remove the parentheses from line 27 and add a "-", and update the index as follows:

line 7: r2.2
line 27: r2.2 - Fall25 public release

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remains an issue with the index in the CHANGELOG file
all the rest is OK

Please try the fixes I propose and if one of them work (option 2 should work), all is OK.

@tanjadegroot
Copy link
Contributor

tanjadegroot commented Sep 16, 2025

HI @tanjadegroot , I've updated the errors in a separate PR which has now been merged to wip main and then synched into the M4 PR. So if you expand the .feature file in the M4 PR code you will see new 400 and 401 errors and the 500 removed.

@Kevsy : I do not see the updates in the M4 release PR ?

BTW: there seems to be an error I saw in the merged PR (#135) in the .feature file:

  • line 33 references 404
  • line 37 references 422
  • line 40 references 400 (btw this is also in other 422 scenarios)

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 17, 2025

Thanks @tanjadegroot - I can see the .feature changes in the M4 PR...now updated to include your suggestions (thx!), note I have corrected the line 37 block to be a 404

CHANGELOG updated too per option 2.

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevsy thanks for the updates - all good now.

LGTM from Release Management

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 17, 2025

Thanks @tanjadegroot ! @maheshc01 please can you re-approve?

@maheshc01
Copy link
Contributor

Approved!

@Kevsy Kevsy merged commit 4f0ce15 into camaraproject:main Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants