-
Notifications
You must be signed in to change notification settings - Fork 4
SimpleEdgeDiscovery r2.2 Fall25 M4 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also corrected two minor typos (no semantic change)
|
|
||
| NOTE: SimpleEdgeDiscovery is part of the EdgeCloud API Sub Project, and was previously developed within the [EdgeCloud](https://github.com/camaraproject/EdgeCloud) repository. Two releases were made within EdgeCloud, v0.81 and r0.9.3-rc. These releases also include the other EdgeCloud APIs and materials, so the changelog below highlights only the changes related to SimpleEdgeDiscovery. Further information and links to the releases in EdgeCloud can be found below. | ||
|
|
||
| # r2.1 - rc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that r2.1 has been replaced with r2.2.
my understanding is that r2.1 needs to be retained and a new section for r2.2 needs to be added. like how the table of contents has it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mahesh - good catch, I've put it back now.
|
looks good |
|
Note to reviewers: I will rebase this M4 PR to account for the fix to #130 (ErrorInfo order reversed) - please wait to review until I have confirmed that has been completed. |
|
OK all good now for the release-management-reviewer to proceed 👍 |
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some error cases are not covered by any tests, for a v2 API I think these should be added, but up to team to decide if to do now or for the next release.
One small fix needed in the Changelog.
all the rest is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no test scenarios for the errors 400 and 401 in the .feature fil
the last scenario on test for error 500 internal can be removed
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
|
Thanks @tanjadegroot - CHANGELOG.MD fix made.
I have created PR #135 to add the 400 and 401 scenarios/remove the #500/tidy up. If a codeowner can approve in time then I can merge into the M4 PR. |
|
HI @tanjadegroot , I've updated the errors in a separate PR which has now been merged to wip main and then synched into the M4 PR. So if you expand the . |
CHANGELOG.md
Outdated
|
|
||
| ## Table of contents | ||
|
|
||
| - [r2.2](#r22---(Fall25-public-release)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remains an issue with the index in the CHANGELOG file
all the rest is OK
Please try the fixes I propose and if one of them work (option 2 should work), all is OK.
@Kevsy : I do not see the updates in the M4 release PR ? BTW: there seems to be an error I saw in the merged PR (#135) in the .feature file:
|
|
Thanks @tanjadegroot - I can see the .feature changes in the M4 PR...now updated to include your suggestions (thx!), note I have corrected the line 37 block to be a 404 CHANGELOG updated too per option 2. |
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kevsy thanks for the updates - all good now.
LGTM from Release Management
|
Thanks @tanjadegroot ! @maheshc01 please can you re-approve? |
|
Approved! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Publication of Fall'25 M4 release r2.2 of SimpleEdgeDiscovery v2.0.0
Which issue(s) this PR fixes:
Fixes # N/A
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.