update Maintainers.md file and README with API information #3
Conversation
ChinaUnicomXiaoDongrui
requested review from
a team and
SentianSun
as code owners
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
I have updated @camaraproject/esim-remote-management_maintainers. With that I can approve the update of the MAINTAINERS.MD file. For the README.md you need still a codeowners review.
Please avoid going forward to mix changes of CODEOWERS and MAINTAINERS.MD file with other changes.
README.md
Outdated
| * Service API(s) “eSimRemoteManagement” (see APIBacklog.md) | ||
| * The API(s) provide(s) the API consumer with the ability to: | ||
| * §Short API scope description§ !! Add here a scope description according to the API proposal | ||
| * Remote management of users' esim card data, including esim activation, esim cancellation, esim query, etc |
There was a problem hiding this comment.
Is esim a common form? Wouldn't be eSIM the correct writing?
Challenges are with lower CamelCase and lower camelCase requirements (e.g. in Spectral linting) ... looking forward for your proposals here.
I'm also not any more sure about the repository name ... eSimRemoteManagement is currently an exception within the API Repositories in CAMARA (only one starting with a lower letter). Asking ChatGPT the clear recommendation is EsimRemoteManagement, which looks somewhat wrong to me.
There was a problem hiding this comment.
@hdamker hello, after consideration by our team, we suggested that this API be named "eSimRemoteManagement". We have made corresponding changes to the "README.md" file to match the repository name.thanks
Update description of the ability of the API in README.md
SentianSun
left a comment
SentianSun
left a comment
There was a problem hiding this comment.
After consideration by our team, we suggested that this API be named "eSimRemoteManagement". We have made corresponding changes to the "README.md" file to match the repository name.
ChinaUnicomXiaoDongrui
left a comment
ChinaUnicomXiaoDongrui
left a comment
There was a problem hiding this comment.
ok
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
renowing my admin approval for the change of MAINTAINERS.MD
3 participants
update Maintainers.md file and README with API information