Skip to content

Add override to overridden destructors #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamaskenez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add override to overridden destructors #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions concurrentqueue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,7 +1785,7 @@ class ConcurrentQueue
new_block_index(0); // This creates an index with double the number of current entries, i.e. EXPLICIT_INITIAL_INDEX_SIZE
}

~ExplicitProducer()
~ExplicitProducer() override
{
// Destruct any elements not yet dequeued.
// Since we're in the destructor, we can assume all elements
Expand Down Expand Up @@ -2428,7 +2428,7 @@ class ConcurrentQueue
new_block_index();
}

~ImplicitProducer()
~ImplicitProducer() override
{
// Note that since we're in the destructor we can assume that all enqueue/dequeue operations
// completed already; this means that all undequeued elements are placed contiguously across
Expand Down