Skip to content

Remove background images redundancy #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
missmatsuko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove background images redundancy #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eefcb4f
Remove redundant background styles when size is cover
missmatsuko Jun 11, 2017
be510ef
Change background centering to keywords
missmatsuko Jun 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions project/examples/css/ex6.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ nav a {
}

/* HOME PAGE STYLES
-----------------------------------------*/
-----------------------------------------*/
.home {
background: url(../images/background-6.jpg) no-repeat 50%;
background: url(../images/background-6.jpg);
background-position: center center;
background-size: cover;
}

Expand Down
5 changes: 3 additions & 2 deletions project/examples/css/ex7.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ nav a {
}

/* HOME PAGE STYLES
-----------------------------------------*/
-----------------------------------------*/
.home {
background: url(../images/background-6.jpg) no-repeat 50%;
background: url(../images/background-6.jpg);
background-position: center center;
background-size: cover;
}

Expand Down
3 changes: 2 additions & 1 deletion project/final/css/final.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ nav a {
/* HOME PAGE STYLES
-----------------------------------------*/
.home {
background: url(../images/background-6.jpg) no-repeat 50%;
background: url(../images/background-6.jpg);
background-position: center center;
background-size: cover;
}

Expand Down
11 changes: 6 additions & 5 deletions slides.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2157,14 +2157,14 @@ <h2>Web Developer + City Girl</h2>
```
/* shorthand */
.home {
background: url(../images/background-6.jpg) no-repeat 50%;
background: url(../images/background-6.jpg) no-repeat center center;
}

/* longhand */
.home {
background-image: url(../images/background-6.jpg);
background-repeat: no-repeat;
background-position: 50%;
background-position: center center;
}
```

Expand Down Expand Up @@ -2193,15 +2193,15 @@ <h2>Web Developer + City Girl</h2>
.home {
background-image: url(../images/background-6.jpg);
background-repeat: no-repeat;
background-position: 50%;
background-position: center center;
background-size: cover;
}
```

To include it using the shorthand property, there's a quirk. It _must_ be included after `background-position`, separated with the `/` character.
```
.home {
background: url(../images/background-6.jpg) no-repeat 50% / cover;
background: url(../images/background-6.jpg) no-repeat center center/ cover;
}
```
</script>
Expand Down Expand Up @@ -2232,7 +2232,8 @@ <h2>Web Developer + City Girl</h2>

```
.home {
background: url(../images/background-6.jpg) no-repeat;
background: url(../images/background-6.jpg);
background-size: center center;
background-size: cover;
}
```
Expand Down