Skip to content

os-release: add "ubuntu" in ID_LIKE #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
valentindavid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

os-release: add "ubuntu" in ID_LIKE #89

valentindavid wants to merge 1 commit into from

Conversation

@valentindavid
Copy link
Collaborator

@valentindavid valentindavid commented Nov 16, 2022

fwupd finds the distro boot directory in EFI partition based on os-release. Because we use ubuntu as directory name, we need to have it in the ID_LIKE so that fwupd finds it.

@valentindavid
os-release: add "ubuntu" in ID_LIKE
3ef661b 
fwupd finds the distro boot directory in EFI partition based on
os-release. Because we use `ubuntu` as directory name, we need to have
it in the ID_LIKE so that fwupd finds it.
@valentindavid valentindavid mentioned this pull request Nov 23, 2022
Merged
@valentindavid
Copy link
Collaborator Author

valentindavid commented Nov 29, 2022

I got some questions about whether it is right to have ID_LIKE=ubuntu. Specially around the fact that Ubuntu Core does not have dpkg or apt.

ID_LIKE is defined by https://www.freedesktop.org/software/systemd/man/os-release.html#ID_LIKE=

[...] It should list identifiers of operating systems that are closely related to the local operating system in regards to packaging and programming interfaces, for example listing one or more OS identifiers the local OS is a derivative from. [...] Build scripts and similar should check this variable if they need to identify the local operating system and the value of ID= is not recognized. Operating systems should be listed in order of how closely the local operating system relates to the listed ones, starting with the closest. [...]

Ubuntu Classic for example has ID_LIKE=debian.

For comparison with some other image based distros based on other distros:

  • Fedora Silverblue has ID=fedora and VARIANT_ID=silverblue. It has rpm. But does not have dnf.
  • Endless OS has ID_LIKE="ubuntu debian". It has dpkg and apt.
  • Steam OS 3 has ID_LIKE=arch. It has pacman.

xnox
xnox suggested changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not an appropriate change.

lots of things will try to indeed use dpkg / apt etc when finding this.

@Meulengracht Meulengracht added the blocked This PR should not be merged and is blocked pending external action label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xnox xnox xnox requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

blocked This PR should not be merged and is blocked pending external action

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentindavid @xnox @Meulengracht