static/writable-paths: set safer options for tmpfs mounts #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
reviewed
Nov 26, 2021
| # generic | ||
| /media none temporary none defaults | ||
| /mnt none temporary none defaults | ||
| /media none temporary none mode=1777,strictatime,nosuid,nodev |
Contributor
There was a problem hiding this comment.
Do we need mode=1777 for /mnt and /media ? Those are not really dirs that have the same semantic as /tmp, they are more dirs with a similar semantic as /run AIUI. Or is there soemthing I'm missing here?
Member
Author
There was a problem hiding this comment.
Without this change, when I run stat on /mnt and /media it actually shows mode 1777 already, so I think that is the default mode. This just shows that more explicitly. So we can remove it I guess, I do not have a strong opinion either way.
alfonsosanchezbeato
force-pushed
the
fix-tmpfs-options
branch
from
4a58c54 to
8b9ee68
Compare
Member
Author
|
I've removed the change for |
anonymouse64
approved these changes
Nov 29, 2021
Contributor
anonymouse64
left a comment
anonymouse64
left a comment
There was a problem hiding this comment.
lgtm thanks for this
Set safer options for mount points backed by tmpfs and writable by all users, so we make sure that nosuid,nodev are set. The options are the default ones recommended by systemd (see /usr/share/systemd/tmp.mount) and we were actually using them already for /tmp in the initramfs.
alfonsosanchezbeato
force-pushed
the
fix-tmpfs-options
branch
from
8b9ee68 to
8135c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set safer options for mount points backed by tmpfs, so we make sure
that nosuid,nodev are set. The options are the default ones
recommended by systemd (see /usr/share/systemd/tmp.mount) and we were
actually using them already for /tmp in the initramfs.