fix(add-model): dials juju as external user on add-model #1722
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luci1900
reviewed
Oct 29, 2025
luci1900
approved these changes
Oct 29, 2025
Contributor
luci1900
left a comment
luci1900
left a comment
There was a problem hiding this comment.
Seems cleaner than granting permissions separately, but obviously incomplete.
kian99
reviewed
Oct 29, 2025
Contributor
kian99
left a comment
kian99
left a comment
There was a problem hiding this comment.
I assume there's no test changes because this was already tested and we're just refactoring?
SimoneDutto
reviewed
Oct 29, 2025
Contributor
|
out of scope for this pr: why don't we add a |
kian99
approved these changes
Oct 29, 2025
alesstimec
force-pushed
the
dial-add-model-as-user
branch
from
246e402 to
e0cbc02
Compare
SimoneDutto
requested changes
Oct 29, 2025
Changes the way JIMM dials the controller when adding a model.
alesstimec
force-pushed
the
dial-add-model-as-user
branch
from
e0cbc02 to
10e5904
Compare
SimoneDutto
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the way JIMM dials the controller when adding a model. This is to achieve Juju 4 compatibility when adding a model - juju 4 has strong referential integrity, so atm JIMM fails to add cloud credentials for an external user, because that external user does not exist in controller's database. After this change, this PR should at least enable us to add credentials and a model.
Engineering checklist
Test instructions