Open
Conversation
AlanGriffiths
requested changes
Feb 6, 2026
Contributor
AlanGriffiths
left a comment
AlanGriffiths
left a comment
There was a problem hiding this comment.
Sorry, don't have good suggestions: center_horizontally_with_clamp_left() is just as confusing and even longer
| namespace | ||
| { | ||
| void clamp_left(Rectangle const& zone, Rectangle& rect) | ||
| void center_horizontally_in_zone(Rectangle const& zone, Rectangle& rect) |
Contributor
There was a problem hiding this comment.
Isn't the new name also confusing? If rect is wider than zone the placement is not centered horizontally, but clamped to the left. (No, that isn't a defense of the old name.)
| } | ||
|
|
||
| void clamp_top(Rectangle const& zone, Rectangle& rect) | ||
| void center_vertically_in_zone(Rectangle const& zone, Rectangle& rect) |
Contributor
There was a problem hiding this comment.
Isn't the new name also confusing? If rect is taller than zone the placement is not centered vertically, but clamped to the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some cleanups that I found while working on #4664 and don't quite fit there.