feat(react/ssr): add StringRenderer and some refactoring#411
Open
alvaromateo wants to merge 10 commits intomainfrom
Open
feat(react/ssr): add StringRenderer and some refactoring#411alvaromateo wants to merge 10 commits intomainfrom
alvaromateo wants to merge 10 commits intomainfrom
Conversation
This allows the client side to import it without fear of importing node dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
This PR introduces some features and breaking changes in
packages/react/ssr.It also fixes the following issues:
Error [ERR_HTTP_HEADERS_SENT]: Cannot write headers after they are sent to the clienterror inapps/react/demowhen running it in production mode (bun run serve)apps/react/demoto the changes done in the SSR module.apps/react/boilerplate-viteto the changes done in the SSR module.In the demo website I have removed:
QA
bun installcd apps/react/demobun run devand check that the website worksbun run serveand check that the website workscd ../boilerplate-vitebun run devand check that the website worksbun run serveand check that the website worksPR readiness check
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.json:check,check:fix, andtest.buildto build the package for development or distribution,build:allto build all artifacts. See CONTRIBUTING.md for details.NOTE
I've increased the major version of the packages I've modified. Please let me know if this is the correct approach or if I need to increase the version of all packages to keep them in sync.