fix(Select): Add support for required attribute#1110
fix(Select): Add support for required attribute#1110kaiweike wants to merge 1 commit intocanonical:mainfrom
Conversation
|
kaiweike is not a collaborator of the repo |
|
This PR is being prevented from merging because it needs to be reviewed on Percy. Go to Percy, find the build relevant to this PR and check if it looks as expected. Once it's approved, add the label |
I encountered an "Access Denied" issue while trying to access the Percy test results. It seems I don't have the necessary permissions. Could someone please assist with granting me the appropriate access? Thank you! |
huwshimi
left a comment
There was a problem hiding this comment.
There are some lint failures on this PR.
| name: "Select multiple", | ||
| }; | ||
|
|
||
| export const RequiredSelect: Story = { |
There was a problem hiding this comment.
I don't think this prop requires an isolated example.
Done
requiredattribute in theSelectcomponent, ensuring it is correctly passed down to the<select>element.requiredattribute.requiredattribute behaves as expected, both when set and not set.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Selectcomponent with therequiredattribute.requiredattribute allows the form to be submitted without selecting an option.Percy steps
Fixes
Fixes: #1045