fix(MainTable): Add keyboard controls to sortable tables#1309
Open
fix(MainTable): Add keyboard controls to sortable tables#1309
Conversation
fc75fe5 to
96ed56b
Compare
Member
Author
|
Blocked pending merge of #1306 . This is still reviewable though - this PR already includes the Vanilla version bump. |
There was a problem hiding this comment.
Pull request overview
This PR adds keyboard controls to sortable tables by wrapping table headers in sort buttons, improving accessibility for keyboard and screen reader users.
Changes:
- Modified
TableHeadercomponent to conditionally render a sort button when bothsortandonSortprops are provided - Updated
MainTableto useonSortprop instead ofonClickfor sort functionality - Updated tests to query for the button element within column headers instead of clicking the header directly
- Upgraded
vanilla-frameworkdependency from 4.39.0 to 4.41.0
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/TableHeader/TableHeader.tsx | Added onSort prop and conditional button wrapper for sortable headers |
| src/components/MainTable/MainTable.tsx | Changed prop name from onClick to onSort for header sort functionality |
| src/components/MainTable/MainTable.test.tsx | Updated tests to target sort buttons and added new keyboard navigation test |
| package.json | Upgraded vanilla-framework to version 4.41.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps