efi/preinstall: Record accepted errors in CheckResult #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
preinstall-record-ignored-errors
branch
from
eedd2ce to
a7fccd4
Compare
This records errors accepted via ActionProceed to a new AcceptedErrors field of CheckResult. There are 2 uses for this: - To use accepted errors to turn on options when generating PCR profiles. The WithAllowInsufficientDmaProtection() opt-in makes use of this new field with this PR. Future PRs will add additional opt-ins which make use of this new field. - To compare future check results against, in order to determine whether anything has changed. At the moment, only the accepted error kinds are retained. However, the new field is a map of ErrorKind to arbitrary JSON value so that a future update can use the arbitrary JSON value to record arguments that can limit the scope of an accepted error. Fixes: FR-11919
chrisccoulson
force-pushed
the
preinstall-record-ignored-errors
branch
from
a7fccd4 to
5d8fe5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records errors accepted via
ActionProceedto a newAcceptedErrorsfield of
CheckResult.There are 2 uses for this:
The
WithAllowInsufficientDmaProtection()opt-in makes use of this newfield with this PR. Future PRs will add additional opt-ins which make
use of this new field.
anything has changed.
At the moment, only the accepted error kinds are retained. However, the
new field is a map of
ErrorKindto arbitrary JSON value so that a futureupdate can use the arbitrary JSON value to record arguments that can
limit the scope of an accepted error.
Fixes: FR-11919