test: build local spread binary #258
Open
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatsuoka
force-pushed
the
work/build-local-spread
branch
4 times, most recently
from
be34961 to
1d99d4e
Compare
cmatsuoka
force-pushed
the
work/build-local-spread
branch
9 times, most recently
from
4005f81 to
517ae65
Compare
cmatsuoka
force-pushed
the
work/build-local-spread
branch
5 times, most recently
from
278398b to
4a6e7bb
Compare
cmatsuoka
force-pushed
the
work/build-local-spread
branch
2 times, most recently
from
3ec64c7 to
6b0abb8
Compare
cmatsuoka
force-pushed
the
work/build-local-spread
branch
from
6b0abb8 to
ba37289
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions test workflow to build a local spread binary from a pinned commit instead of relying on a potentially outdated system-provided version. The PR also adds explicit unit test execution and updates the Google Cloud credentials handling to use a file-based approach.
Changes:
- Added a dedicated step to run Go unit tests
- Introduced a step to build a specific version of the spread binary from source
- Modified the spread configuration to use file-based Google Cloud credentials instead of environment variables
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/test.yaml | Added unit test execution, local spread binary build from pinned commit, and updated credential handling to use key.json file |
| spread.yaml | Changed Google Cloud key configuration from environment variable to file-based approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmatsuoka
force-pushed
the
work/build-local-spread
branch
from
8cfdbf6 to
1de9c3a
Compare
Don't rely on GitHub runners providing a (potentially outdated) spread binary. Instead, check out a reference version and build a local binary to be used in the github CI test. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
work/build-local-spread
branch
from
1de9c3a to
1de5e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on GitHub runners providing a (potentially outdated)
spread binary. Instead, check out a reference version and build a
local binary to be used in the github CI test.