Skip to content

feat: add attribute support to CTA section#5723

Merged
jmuzina merged 2 commits intocanonical:mainfrom
britneywwc:cta-pattern-id
Dec 17, 2025
Merged

feat: add attribute support to CTA section#5723
jmuzina merged 2 commits intocanonical:mainfrom
britneywwc:cta-pattern-id

Conversation

@britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Dec 11, 2025

Done

Fixes WD-32082

QA

  • Go to /docs/patterns/cta-section
  • See that the "Default full width" example has ID attached to the section
  • Scroll down to the "Jinja macro" section and check that attrs has been added

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

@britneywwc
Copy link
Contributor Author

CC @petesfrench

@jmuzina jmuzina merged commit 625c7d8 into canonical:main Dec 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants