fix: prevent double quotes in pull quotes#5728
Open
tanujbhaud wants to merge 3 commits intocanonical:mainfrom
Open
fix: prevent double quotes in pull quotes#5728tanujbhaud wants to merge 3 commits intocanonical:mainfrom
tanujbhaud wants to merge 3 commits intocanonical:mainfrom
Conversation
Calendar and clock icons in date/time inputs were difficult to see in dark mode. Applied filter: invert(1) to webkit-calendar-picker-indicator pseudo-elements when inside .is-dark containers. Fixes canonical#5696
Added quotes: none and reset ::before/::after on pull quote containers to prevent browser default blockquote styles from adding extra quotes.
|
tanujbhaud is not a collaborator of the repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
quotes: noneto the.p-pull-quotemixin to prevent browser default quotes from appearing when the pattern is applied to a<blockquote>element.::beforeand::aftercontent on the pull quote container tononeto avoid overlapping pseudo-elements in environments with global blockquote styles.Fixes #5711
QA
blockquoteelement:Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨. (This is aBug 🐛)package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
Original bug screenshots can be found in the issue #5711.

Before:
After:
