-
Notifications
You must be signed in to change notification settings - Fork 190
feat(WD-33316): Add blocks support to Hero section #5747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e0ec49b
feat: add blocks support to Hero section
muhammad-ali-pk f49c7d0
address comments
muhammad-ali-pk d6b26f9
update basic section
muhammad-ali-pk 3aea141
update hero examples to use blocks
muhammad-ali-pk 5833843
update docs
muhammad-ali-pk 6195a55
update releases and package version
muhammad-ali-pk 72b5a34
Merge remote-tracking branch 'origin/main' into update-hero
muhammad-ali-pk 0c165d0
tidy up example set
muhammad-ali-pk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| {% extends "_layouts/examples.html" %} | ||
| {% from "_macros/vf_hero.jinja" import vf_hero %} | ||
|
|
||
| {% block title %}Hero | CTA block{% endblock %} | ||
| {% block standalone_css %}patterns_all{% endblock %} | ||
|
|
||
| {% set is_paper = true %} | ||
| {% block content %} | ||
|
|
||
| {% call(slot) vf_hero( | ||
| title_text='H1 - ideally one line, up to two', | ||
| subtitle_text='H2 placeholder - aim for one line, 2 is acceptable, more - use a paragraph', | ||
| layout='50/50', | ||
| blocks=[ | ||
| { | ||
| "type": "cta-block", | ||
| "item": { | ||
| "primary": { | ||
| "content_html": "Contact us", | ||
| "attrs": { | ||
| "href": "#" | ||
| } | ||
| }, | ||
| "link": { | ||
| "content_html": "Learn more ›", | ||
| "attrs": { | ||
| "href": "#" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| ) -%} | ||
| {%- if slot == 'description' -%} | ||
| <p> | ||
| Generally, the height of the right hand side of a 50/50 split should contain more content than the left | ||
| hand side. | ||
| </p> | ||
| {%- endif -%} | ||
| {% endcall -%} | ||
|
|
||
| {% endblock %} |
26 changes: 26 additions & 0 deletions
26
templates/docs/examples/patterns/hero/description-block.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| {% extends "_layouts/examples.html" %} | ||
| {% from "_macros/vf_hero.jinja" import vf_hero %} | ||
|
|
||
| {% block title %}Hero | Description block{% endblock %} | ||
| {% block standalone_css %}patterns_all{% endblock %} | ||
|
|
||
| {% set is_paper = true %} | ||
| {% block content %} | ||
|
|
||
| {% call(slot) vf_hero( | ||
| title_text='H1 - ideally one line, up to two', | ||
| subtitle_text='H2 placeholder - aim for one line, 2 is acceptable, more - use a paragraph', | ||
| layout='50/50', | ||
| blocks=[ | ||
| { | ||
| "type": "description", | ||
| "item": { | ||
| "type": "text", | ||
| "content": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate." | ||
| } | ||
| } | ||
| ] | ||
| ) -%} | ||
| {% endcall -%} | ||
|
|
||
| {% endblock %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.