Skip to content

feat(WD-33316): Add blocks support to Hero section#5747

Merged
muhammad-ali-pk merged 8 commits intomainfrom
update-hero
Feb 3, 2026
Merged

feat(WD-33316): Add blocks support to Hero section#5747
muhammad-ali-pk merged 8 commits intomainfrom
update-hero

Conversation

@muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 29, 2026

Done

  • Added blocks support, to replace slots. The slots will keep working as expected, however, the new recommended way is to use blocks.

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Issue

Fixes WD-33316

@webteam-app
Copy link

@muhammad-ali-pk muhammad-ali-pk changed the title feat(WD-33316): Add " feat(WD-33316): Add blocks support to Hero section Jan 29, 2026
@muhammad-ali-pk muhammad-ali-pk force-pushed the update-hero branch 3 times, most recently from fdc9ae8 to a39a9cd Compare January 29, 2026 07:04
@muhammad-ali-pk muhammad-ali-pk requested review from huwshimi and removed request for huwshimi January 29, 2026 09:38
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move slots from the top of the page (and maybe add a notice) to make it clear that users should be using blocks?

'Signpost image' block variant is broken on medium screens:

Image

@muhammad-ali-pk
Copy link
Contributor Author

@petesfrench Thanks for the review, I've addressed your comments. Please have another look.
Also,

Should we move slots from the top of the page (and maybe add a notice) to make it clear that users should be using blocks?

I realized that the listed examples were still using slots, which would be confusing for users as the slots section mentions those are deprecated. I have updated all the listed examples to use blocks along with the deprecation notice for slots within the slots section. This way, there should be no more confusion between the recommended way and deprecated way.

'Signpost image' block variant is broken on medium screens:

Should be fixed now

Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammad-ali-pk muhammad-ali-pk merged commit b82b3c6 into main Feb 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants