Skip to content

feat: add padding variants for Resources pattern#5748

Merged
britneywwc merged 2 commits intocanonical:mainfrom
britneywwc:padding-resources
Jan 30, 2026
Merged

feat: add padding variants for Resources pattern#5748
britneywwc merged 2 commits intocanonical:mainfrom
britneywwc:padding-resources

Conversation

@britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 30, 2026

Done

  • Added padding param to Resources pattern

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Fixes

WD-33353

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you
Please hold off on the release for this, I have another PR in review, which can also be delivered in the same version.

@britneywwc britneywwc merged commit e47209c into canonical:main Jan 30, 2026
7 checks passed
@britneywwc britneywwc deleted the padding-resources branch January 30, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants