Skip to content

feat: add padding variants for Resources pattern #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
britneywwc merged 2 commits into from
Jan 30, 2026
Merged

feat: add padding variants for Resources pattern #5748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f53fa0c
feat: add padding variants for Resources pattern
britneywwc Jan 30, 2026
63a100b
Address code comment
britneywwc Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vanilla-framework",
"version": "4.41.0",
"version": "4.42.0",
"author": {
"email": "webteam@canonical.com",
"name": "Canonical Webteam"
Expand Down
6 changes: 6 additions & 0 deletions releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- version: 4.42.0
features:
- component: Resources
url: /docs/patterns/resources
status: Updated
notes: Added a new <code>padding</code> parameter to customize the section padding.
- version: 4.41.0
features:
- component: Table
Expand Down
14 changes: 12 additions & 2 deletions templates/_macros/vf_resources.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,15 +318,25 @@
]
}
]
@param padding (string) - Optional bottom padding for the section
#}
{% macro vf_resources(title={}, blocks=[], caller=None) %}
{% macro vf_resources(title={}, blocks=[], caller=None, padding="default") %}
{%- set description = blocks | selectattr("type", "equalto", "description") | first -%}
{%- set cta = blocks | selectattr("type", "equalto", "cta-block") | first -%}
{%- set resources = blocks | selectattr("type", "equalto", "resources") | first -%}
{%- set render_images = resources.get("render_images", true) -%}
{%- set render_categories = resources.get("render_categories", true) -%}
{%- set is_text_only = not (render_images or render_categories) -%}
<section class="p-section">
{%- set padding = padding | trim -%}
{%- if padding not in ["deep", "shallow", "default"] -%}
{%- set padding = "default" -%}
{%- endif -%}
{%- if padding == "default" -%}
{%- set padding_classes = "p-section" -%}
{%- else -%}
{%- set padding_classes = "p-section--" + padding -%}
{%- endif -%}
<section class="{{ padding_classes }}">
<div class="grid-row--50-50{% if is_text_only %}-on-large{% endif %}{% if not is_text_only %} p-section--shallow{% endif %}">
{{- vf_section_top_rule("default") -}}
<div class="grid-col">{{- _title_block(title) -}}</div>
Expand Down
20 changes: 20 additions & 0 deletions templates/docs/patterns/resources/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,26 @@ The Resources block allows you to specify categories and resource items to appea
Time element attributes object, see <a href="/docs/building-vanilla#attribute-forwarding">attribute forwarding</a>
</td>
</tr>
<tr>
<td>
<code>padding</code>
</td>
<td>
No
</td>
<td>
One of:<br>
<code>'deep'</code>,<br>
<code>'shallow'</code>,<br>
<code>'default'</code>
</td>
<td>
<code>'default'</code>
</td>
<td>
Padding variant for the section
</td>
</tr>
</tbody>
</table>
</div>
Expand Down