Revised security guide #2223
Draft
Revised security guide #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finkmanAtSap
requested changes
Nov 21, 2025
Collaborator
finkmanAtSap
left a comment
finkmanAtSap
left a comment
There was a problem hiding this comment.
I did not do an in-depth review but I found some things while skimming through
BraunMatthias
force-pushed
the
revised-security-guide
branch
2 times, most recently
from
bfad258 to
cb794d1
Compare
added 21 commits
November 27, 2025 13:35
PDT42
reviewed
Dec 15, 2025
PDT42
reviewed
Dec 15, 2025
| </div> | ||
|
|
||
| <div class="node"> | ||
| TODO |
Contributor
There was a problem hiding this comment.
I don't think disabling auth is valid for Node.js ...
Contributor
Author
There was a problem hiding this comment.
is there no way to fully overrule?
Contributor
There was a problem hiding this comment.
I am not aware of a way to disable just authentication without busting authorization in the process and I am uncertain about how the service mesh would replace the functionality.
Contributor
There was a problem hiding this comment.
we have a dummy auth strategy
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Patrice Bender <patrice.bender@sap.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Co-authored-by: Paul <paul.erlenwein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.