Skip to content

Conversation

@adityashirsatrao007
Copy link

@adityashirsatrao007 adityashirsatrao007 commented Dec 8, 2025


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

Copilot AI review requested due to automatic review settings December 8, 2025 11:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors import statements in the hydra-prelude and hydra-node packages to use package-qualified imports by enabling the PackageImports language extension. This makes dependencies more explicit and helps avoid ambiguity when multiple packages expose modules with the same name.

Key changes:

  • Enabled PackageImports extension in both hydra-prelude.cabal and hydra-node.cabal
  • Added explicit package qualifiers to all imports (e.g., import "aeson" Data.Aeson instead of import Data.Aeson)
  • Applied the change consistently across both the prelude module and the main node module

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
hydra-prelude/hydra-prelude.cabal Adds PackageImports language extension to enable package-qualified imports
hydra-prelude/src/Hydra/Prelude.hs Refactors all import statements to include explicit package qualifiers
hydra-node/hydra-node.cabal Adds PackageImports language extension to enable package-qualified imports
hydra-node/src/Hydra/Node.hs Refactors import statements to include explicit package qualifiers for external dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@locallycompact
Copy link
Contributor

Thanks! Could you squash the commits?

@locallycompact
Copy link
Contributor

Btw hit nix fmt to autofix all the formatting issues.

Enables PackageImports extension and qualifies imports to avoid ambiguity and improve clarity.
@adityashirsatrao007 adityashirsatrao007 force-pushed the adityashirsatrao007/2398-qualified-imports branch from 0bda570 to e1eb754 Compare December 8, 2025 15:06
@adityashirsatrao007
Copy link
Author

Btw hit nix fmt to autofix all the formatting issues.

Done

@noonio
Copy link
Contributor

noonio commented Dec 9, 2025

Thanks @adityashirsatrao007 for submitting this!

As discussed, please:

  1. run nix fmt,
  2. squash the commits

then we will be happy to merge!

@adityashirsatrao007
Copy link
Author

I'll update it in few hours

@noonio noonio closed this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants