-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add Rich-based TUI for job monitoring and management #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boshyxd
wants to merge
11
commits into
dev
Choose a base branch
from
feature/rich-tui-clean
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes - Added model_dtype, action_dtype, and target_dtype to Config class - Added validation for dtype options (float32, float16, bfloat16 for model/target; int32, int64 for action) - Updated configuration.json to include Data Types section - Updated section_mapping in to_json method to handle new dtype section Closes #9
- Created detailed GPU_PERFORMANCE_TIPS.md with JAX best practices - Added gpu_optimized_train.py script with pre-configured environment flags - Documented XLA optimizations, mixed precision, and multi-GPU settings - Included code examples, benchmarking tips, and troubleshooting guide - Analyzed CuMind codebase for specific optimization opportunities Closes #28
Signed-off-by: jonashall8 <121309342+jonashall8@users.noreply.github.com>
Signed-off-by: jonashall8 <121309342+jonashall8@users.noreply.github.com>
Implements GitHub issue #7 - New TUI Interface for job monitoring. Added multiple TUI implementations: - Simple Rich TUI (--simple-tui): Clean dashboard with real-time updates - Interactive Rich TUI (--interactive-tui): Full keyboard controls - Basic Rich TUI (--rich-tui): Demonstration of Rich capabilities - Original Textual TUI (--tui): Preserved existing implementation Features: - Real-time job monitoring with progress bars - Training metrics visualization (rewards, loss, learning rate) - Job queue management with status indicators - Color-coded job statuses (running, completed, failed, paused) - ASCII reward history charts - Multi-job support with concurrent execution limits - Job manager for process management Added comprehensive test suite with 31 tests covering: - All data structures and enums - UI component creation - Job management functionality - Process communication CLI updates: - Added --simple-tui, --rich-tui, --interactive-tui flags - Made --config optional when using TUI modes
- Remove decorative elements from UI components - Simplify panel titles and headers - Remove excessive inline comments - Maintain consistent formatting across all TUI modules
974ea01 to
f558ef4
Compare
Contributor
|
Sorry, I don't have time to review such a large feature right now. Please rebase if you want to keep working on it. If you limit changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements GitHub issue #7 - New TUI Interface for job monitoring.
Added multiple TUI implementations:
Features:
Added comprehensive test suite with 31 tests covering:
CLI updates: