(feat) added directories of configuration.json files for every category and game #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machine-moon
requested changes
Jul 20, 2025
Contributor
machine-moon
left a comment
machine-moon
left a comment
There was a problem hiding this comment.
i changed my opinion can you move them outside of src
ls cumind:
src/ tests/ gymnasium/
Contributor
Author
|
everything should be good now |
thomasnol
requested review from
machine-moon
and removed request for
machine-moon
machine-moon
approved these changes
Jul 27, 2025
Contributor
machine-moon
left a comment
machine-moon
left a comment
There was a problem hiding this comment.
Weird how some of the config files have this:
"action_space_size": [
1
],
"observation_shape": [
3
]
they should be on same line if you are using the ./scripts/exportconfig.py
No worries though, they'll get formatted sooner or later, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Summary
Describe the purpose and key changes of this PR.
Change Type
Related Issues
What Was Changed
Testing
Checklist
Screenshots / Notes