Expanded diagram to include git pull using Mermaid JS tool.#256
Merged
Expanded diagram to include git pull using Mermaid JS tool.#256
Conversation
Collaborator
Author
|
I like this new Mermaid drawing tool - many thanks for bringing it to our attention @thomaskileyukaea. |
Collaborator
Author
|
I have now removed the link to the Mermaid-generated SVG and kept the local SVG only, after having a conversation with @steve-crouch on 2023-11-07 about adding another dependency to the lesson material, which we are not sure of the lifetime or support of (in the future). |
steve-crouch
approved these changes
Nov 9, 2023
Collaborator
steve-crouch
left a comment
steve-crouch
left a comment
There was a problem hiding this comment.
A couple of comments, but is much clearer with regards to the local or remote context for git operations.
| your local copy (using `git fetch` or `git pull`) to keep the two in sync | ||
| in order to collaborate (with a bonus that your work also gets backed up to another machine). | ||
|
|
||
| {: .image-with-shadow width="600px"} |
Collaborator
There was a problem hiding this comment.
Does this now need to be removed since we have the more sustainable replacement?
Collaborator
Author
|
Thank you very much for the review @steve-crouch. Merging next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173 but keeping this a draft PR for the time being as it needs the new layout that supports mermaid drawings (in PR #226), unless we just decide to keep the SVG version of the new diagram.
Also improves the wording a bit around Git infrastructure.