Use BeanTableSchemaParams in TableSchemaFactory #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericloe-cash
force-pushed
the
ericloe/bean_param
branch
from
99ae3c6 to
af1b777
Compare
tempest2/src/main/kotlin/app/cash/tempest2/internal/TableSchemaFactory.kt
Outdated
Show resolved
Hide resolved
stuartwdouglas
approved these changes
Oct 20, 2025
rnc505
approved these changes
Oct 20, 2025
rnc505
left a comment
rnc505
left a comment
There was a problem hiding this comment.
lgtm and unblocks janus playpen, I'm all for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported directly from the SDK TableSchema.fromClass with support for BeanTableSchemaParams.
The modification is to use BeanTableSchemaParams in fromBean:
Generally, this method should be preferred over fromBean(Class) because it allows you to use a custom MethodHandles.Lookup instance, which is necessary when your application runs in an environment where your application code and dependencies like the AWS SDK for Java are loaded by different classloaders.